Do not select target range going to definition

[Congyuwang]

Release Notes:

-Fixed #11347 , do not select target range going to definition. Just place the cursor at the start of target range.

[Congyuwang]

Seems to me that when using VIM mode, only the first character got selected anyway. So that letting the cursor go to the beginning of the range of definition, seems more consistent across VIM and non-VIM mode.

[ConradIrwin]

@Congyuwang thanks for this!

It seems like there's a few cases to consider:

• If you jump to definition of a non-module (e.g. a function, field, type, variable). It currently highlights the name of the definition not the whole definition.
• If you jump to the definition of a rust module it currently highlights the entire file (Rust: jump to definition (Command click) should not enclose the target with a text selection #11347)

I think this change will change the behavior in both of these cases; which might be ok, but I wonder if we should more narrowly special case this to just work-around the bug in rust analyzer. i.e. if the returned range is > 1 line, make it just highlight the first character, otherwise keep the selection?

Otherwise we could deliberately not highlight the definition when clicking on it, but it is kind of nice that that behavior matches search (even if it differs from vim).

What do you think?

[Congyuwang]

I think that would be good.

[Congyuwang]

It now works nicely!

[Congyuwang]

Just noticed that the old release note is not very accurate.

[JosephTLyons]

Just noticed that the old release note is not very accurate.

About to build the release notes for today's release - what are you thinking the release note for this item should be?

[Congyuwang]

Maybe the following:

Release Notes:

-Fixed #11347 , Do not select target range going to definition when the range has more than one line.