Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reveal_path blocks on linux #11702

Merged
merged 1 commit into from May 14, 2024

Conversation

FlafyDev
Copy link
Contributor

@FlafyDev FlafyDev commented May 11, 2024

If you go to the file tree and press "x" (which is "project_panel::RevealInFinder"). It will open the default file manager(in my case nautilus). But on Linux it makes Zed unresponsive. This fixes that.

Release Notes:

  • N/A

Copy link

cla-bot bot commented May 11, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @FlafyDev on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@FlafyDev
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 11, 2024
Copy link

cla-bot bot commented May 11, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant maxdeviant changed the title fix: reveal_path blocks on linux Fix reveal_path blocks on linux May 11, 2024
Copy link
Contributor

@apricotbucket28 apricotbucket28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that_in_background spawns an additional thread, we should prefer that_detached.

Also, the call above should be replaced too.

@FlafyDev
Copy link
Contributor Author

that_in_background spawns an additional thread, we should prefer that_detached.

Also, the call above should be replaced too.

done

@mikayla-maki
Copy link
Contributor

Thanks!

@mikayla-maki mikayla-maki merged commit c8ddde2 into zed-industries:main May 14, 2024
8 checks passed
osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this pull request May 18, 2024
If you go to the file tree and press "x" (which is
"project_panel::RevealInFinder"). It will open the default file
manager(in my case nautilus). But on Linux it makes Zed unresponsive.
This fixes that.

Release Notes:

- Fixed Zed blocked after opening file manager in the file tree on
Linux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants