Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Vue language server to 1.8 #9846

Merged
merged 2 commits into from Mar 27, 2024
Merged

Pin Vue language server to 1.8 #9846

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
032e376
fix: vue lsp not work
Dunqing Mar 27, 2024
fec57c3
Update crates/languages/src/vue.rs
mrnugget Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions crates/languages/src/vue.rs
View file
Open in desktop
Expand Up @@ -48,10 +48,12 @@ impl super::LspAdapter for VueLspAdapter {
_: &dyn LspAdapterDelegate,
) -> Result<Box<dyn 'static + Send + Any>> {
Ok(Box::new(VueLspVersion {
vue_version: self
.node
.npm_package_latest_version("@vue/language-server")
.await?,
// TODO: Temporarily fixed to 1.8 as @vue/language-server 2.0 is not yet supported
// vue_version: self
// .node
// .npm_package_latest_version("@vue/language-server")
// .await?,
mrnugget marked this conversation as resolved.
Show resolved Hide resolved
vue_version: "1.8".to_string(),
ts_version: self.node.npm_package_latest_version("typescript").await?,
}) as Box<_>)
}
Expand Down