Amend pnpm_lock_sync_test to fail anytime pnpm is sad (not just if the lockfile is out of date) #3606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2023
Merged
Zemnmez
force-pushed
the
pr3606
branch
2 times, most recently
from
bd6169b
to
7f30293
Compare
Zemnmez
force-pushed
the
pr3606
branch
2 times, most recently
from
13c5926
to
8cfadbd
Compare
|
This IS currently broken, but I don't want anything else being pushed to main, because Mend is still generating patches that don't have lockfile changes in them. |
…e lockfile is out of date) Move pnpm test into presubmit (it breaks out of the sandbox) Amend pnpm lock sync test accounting for upstream fix. pnpm/pnpm#6913 (comment) Revert all changes to package.json since lockfile test was broken.
|
rip to the build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amend pnpm_lock_sync_test to fail anytime pnpm is sad (not just if the lockfile is out of date)
Move pnpm test into presubmit (it breaks out of the sandbox)
Amend pnpm lock sync test accounting for upstream fix.
pnpm/pnpm#6913 (comment)
Revert all changes to package.json since lockfile test was broken.
Stack created with Sapling. Best reviewed with ReviewStack.