-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model_version_id
as part of the Model config
#2703
Add model_version_id
as part of the Model config
#2703
Conversation
…ep-and-pipeline-runs-improvements
Important Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment regarding the naming, otherwise, the changes look good.
id_
as part of the Model configmodel_version_id
as part of the Model config
…ep-and-pipeline-runs-improvements
…ep-and-pipeline-runs-improvements
…ep-and-pipeline-runs-improvements
Describe changes
I added
model_version_id
as a public field of the Model. It can be used to configure a Model Version using ID or will be used to represent a more stable way of working with pipelines under Model Version, for example, if the pipeline was started with the version set to some stage - the same model ID will be used in all steps using this configuration, regardless of the fact, that some other model version could have been moved to that stage during the pipeline run.I added a specific test case for the following case:
- Pipeline starts with Model
foo
stagestaging
- Do some steps
- Some step moves another model version to
staging
- Validate that subsequent steps can still work with the initial model version
@Cahllagerfeld @atzin-escandia , FYI, now the Step or Model config will have a field
model
as before, but now it is enriched withmodel_version_id
. The logic remains the same: check StepRun config for the model, if not null pickid_
and leave, if null check PipelineRun config for the model, if not null pickmodel_version_id
and leave.Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes