arch: make EXCEPTION_STACK_TRACE depends on ARCH_HAS_STACK_TRACE
#72863
+47
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycsin
commented
May 16, 2024
| depends on PRINTK | ||
| depends on DEBUG_INFO | ||
| depends on !OMIT_FRAME_POINTER |
There was a problem hiding this comment.
removed as this can depend on implementations in the architecture
ycsin
force-pushed
the
pr/ARCH_HAS_STACK_TRACE
branch
from
dcc5fbd
to
b575a4f
Compare
Create an intermediary `CONFIG_ARCH_HAS_STACK_TRACE` that is enabled by architectures based on respective conditions and have the `CONFIG_EXCEPTION_STACK_TRACE` depends on that. Then, update all occurances of - `CONFIG_RISCV_EXCEPTION_STACK_TRACE` & - `CONFIG_x86_EXCEPTION_STACK_TRACE` The dependencies of `arm64` is a little different, it depends on `CONFIG_ARM64_ENABLE_FRAME_POINTER` to imply that the stack trace is enabled, update that to `CONFIG_EXCEPTION_STACK_TRACE` as well. Signed-off-by: Yong Cong Sin <ycsin@meta.com>
ycsin
force-pushed
the
pr/ARCH_HAS_STACK_TRACE
branch
from
b575a4f
to
74861d6
Compare
ycsin
added
area: Kernel
area: RISCV
zephyrbot
added
area: X86
zephyrbot
requested review from
andyross,
carlocaione,
ceolin,
dcpleung,
fkokosinski,
jhedberg,
kgugala,
laurenmurphyx64,
najumon1980,
nashif,
npitre,
povergoing,
SgrrZhf and
tbursztyka
|
Hm... usually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an intermediary
CONFIG_ARCH_HAS_STACK_TRACEthat is enabled by architectures based on arch-specific conditions and have theCONFIG_EXCEPTION_STACK_TRACEdepends on that.Then, update all occurances of
CONFIG_RISCV_EXCEPTION_STACK_TRACE&CONFIG_x86_EXCEPTION_STACK_TRACEThe dependencies of
arm64is a little different, it depends onCONFIG_ARM64_ENABLE_FRAME_POINTERto imply that the stack trace is enabled, update that toCONFIG_EXCEPTION_STACK_TRACEas well.