Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore: Ignore myresults.xml files #72870

Merged

Conversation

omkar3141
Copy link
Collaborator

These files are created as a result of local babblesim test runs and can be safely ignored.

@omkar3141 omkar3141 requested review from fabiobaltieri, ludvigsj, carlescufi, alxelax and Andrewpini and removed request for fabiobaltieri May 16, 2024 11:33
fabiobaltieri
fabiobaltieri previously approved these changes May 16, 2024
nashif
nashif previously approved these changes May 16, 2024
@nashif nashif added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label May 16, 2024
Copy link
Member

@aescolar aescolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of amusing how a "whatever" name in a documentation example ends up being used by many.
Anyhow, the default for this is actually "RunResults.xml" one level above the zephyr repo.
So maybe we should just change the doc to say "RunResults.xml" instead and have this be the one we ignore?
Anyhow, this can also be merged as is, it does no harm.

.gitignore Outdated
@@ -85,3 +85,6 @@ ModulesMaintainers.txt
Nits.txt
Pylint.txt
YAMLLint.txt

# Local test run outputs
myresults.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:), I would put it next to the other tests results in line 40ish

These files are created as a result of local babblesim test runs
and can be safely ignored.

Signed-off-by: Omkar Kulkarni <omkar.kulkarni@nordicsemi.no>
@omkar3141 omkar3141 dismissed stale reviews from nashif and fabiobaltieri via 772f370 May 27, 2024 12:42
@omkar3141 omkar3141 force-pushed the omku/ignore_results_xml_files branch from cc15410 to 772f370 Compare May 27, 2024 12:42
@omkar3141 omkar3141 requested review from aescolar and nashif May 27, 2024 12:42
@aescolar aescolar merged commit 771afc3 into zephyrproject-rtos:main May 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants