Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: controller: Add BT_CTLR_HCI Kconfig option #72871

Merged
merged 1 commit into from
May 20, 2024

Conversation

jhedberg
Copy link
Member

@jhedberg jhedberg commented May 16, 2024

Add a new option to split off the building of the HCI layer of the controller. This layer is not needed by the controller unit tests, and becomes problematic with the planned change to use devicetree for HCI drivers (causing CI failures in #72323).

@jhedberg
Copy link
Member Author

@tejlmand any idea what the Compliance failure about a non-existing BOARD_UNIT_TESTING option is about? When I built locally I could verify that it does exist. In fact I have these two in build/zephyr/.config when I build a controller unit test:

CONFIG_BOARD_UNIT_TESTING=y
CONFIG_BOARD_UNIT_TESTING_UNIT_TESTING=y

@tejlmand
Copy link
Collaborator

@tejlmand any idea what the Compliance failure about a non-existing BOARD_UNIT_TESTING option is about?

because when running compliance on the Kconfig tree, then only the pure Zephyr tree is used and hence the Kconfig parts of the unit testing board is not sourced.

One reason is to avoid such test settings leaking into the production code 😉

@tejlmand
Copy link
Collaborator

see proposal here: https://discord.com/channels/720317445772017664/1240262352427810888/1240648479504601119

Copy link
Contributor

@cvinayak cvinayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "Bluetooth: Controller:..." in commit title (BT Spec no longer uses lower case controller in its texts)

Add a new option to split off the building of the HCI layer of the
controller. This layer is not needed by the controller unit tests, and
becomes problematic with the planned change to use devicetree for HCI
drivers.

Signed-off-by: Johan Hedberg <johan.hedberg@gmail.com>
@jhedberg
Copy link
Member Author

Use "Bluetooth: Controller:..." in commit title (BT Spec no longer uses lower case controller in its texts)

Done.

@fabiobaltieri fabiobaltieri merged commit 274507f into zephyrproject-rtos:main May 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants