-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stm32 rtc driver using the stm32 LL_RTC Time Date init functions #72880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
ajarmouni-st,
bjarki-trackunit,
gautierg-st and
GeorgeCGV
May 16, 2024 13:44
FRASTM
force-pushed
the
stm32_rtc
branch
2 times, most recently
from
May 16, 2024 14:40
09d4e5a
to
954f40c
Compare
ajarmouni-st
requested changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please put the modifs related to RTC alarm in a separate commit?
FRASTM
force-pushed
the
stm32_rtc
branch
3 times, most recently
from
May 21, 2024 14:22
98cad92
to
90fa268
Compare
rebase on ec0e2d6 |
ajarmouni-st
requested changes
May 21, 2024
FRASTM
force-pushed
the
stm32_rtc
branch
4 times, most recently
from
May 22, 2024 07:25
592db1d
to
8943913
Compare
ajarmouni-st
previously approved these changes
May 22, 2024
gautierg-st
previously approved these changes
May 22, 2024
bjarki-trackunit
previously approved these changes
May 22, 2024
FRASTM
dismissed stale reviews from bjarki-trackunit, gautierg-st, and ajarmouni-st
via
May 22, 2024 09:57
72e7a92
Add a timeout to the tests/drivers/rtc_api testcase so twister can end properly when running with twister. Signed-off-by: Francois Ramu <francois.ramu@st.com>
Set a Calendar using the LL functions LL_RTC_TIME_Init and LL_RTC_DATE_Init. Add more DBG info On the stm32F2 serie, check RS Flag after setting calendar registers. Signed-off-by: Francois Ramu <francois.ramu@st.com>
Note that the Init of the alarm has no need for BCD2BIN conversion, the LL_RTC_ALMx_Init will do. Add more log debug The driver must clear the ALARM enable bit before wrting the alarm registers. Signed-off-by: Francois Ramu <francois.ramu@st.com>
ajarmouni-st
approved these changes
May 22, 2024
gautierg-st
approved these changes
May 23, 2024
bjarki-trackunit
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the LL_RTC_TIME_Init and LL_RTC_DATE_Init and
let the LL functions manage the Enter init mode and the Write Protection of the RTC calendar Registers
Increase the Timeout when executing the tests/drivers/rtc/rtc_api on stm32 targets
This will let test ends correctly when waiting for the alarm flags
Fixes #72888