drivers: entropy: stm32 entropy driver add semaphore protection #72882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
requested changes
May 16, 2024
There was a problem hiding this comment.
Issue is that in release_rng following is done:
entropy_stm32_suspend();
#if defined(CONFIG_SOC_SERIES_STM32WBX) || defined(CONFIG_STM32H7_DUAL_CORE)
z_stm32_hsem_unlock(CFG_HW_RNG_SEMID);
#endif /* CONFIG_SOC_SERIES_STM32WBX || CONFIG_STM32H7_DUAL_CORE */
So current implementation will end up with 2 consecutive z_stm32_hsem_unlock.
To take this into account, what about:
Calling release_rng instead of entropy_stm32_suspend and call lock semaphore before calls in entropy_stm32_rng_pm_action.
(maybe some function renaming would be required in the end to make all this more clear)
|
change as suggested |
FRASTM
force-pushed
the
issue72640
branch
2 times, most recently
from
72e27e2
to
5945746
Compare
Add a semaphore to protect the disable access to the RNG peripheral when the PM is going to suspend mode. The change does not affect other stm32 than CONFIG_SOC_SERIES_STM32WBX or CONFIG_STM32H7_DUAL_CORE Signed-off-by: Francois Ramu <francois.ramu@st.com>
erwango
approved these changes
Jun 4, 2024
gautierg-st
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the PM is going to suspend mode, this change is adding a semaphore to protect the access to the RNG peripheral
Fixes #72640