-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: mcuboot: add boot_request_upgrade() return value check #72883
tests: mcuboot: add boot_request_upgrade() return value check #72883
Conversation
butok
commented
May 16, 2024
- Adds boot_request_upgrade() return value check.
- Avoid repeating resets if the upgrade request fails.
- Adds boot_request_upgrade() return value check. - Avoid repeating resets if the upgrade request fails. Signed-off-by: Andrej Butok <andrey.butok@nxp.com>
2f9710d
to
5b04c66
Compare
@butok I meet failure on lpcexpresso55s36
|
printk("Failed to request upgrade: %d", err); | ||
} else { | ||
printk("Secondary application ready for swap, rebooting\n"); | ||
sys_reboot(SYS_REBOOT_COLD); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth adding a k_sleep() here for 200ms or so to ensure message is printed (optional)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth adding a k_sleep() here for 200ms or so to ensure message is printed (optional)
It 's not needed. It is printed on all tested platforms.
Tested on other LPC55S69, and it is fine. After mass erase (Jlink), LPC55S36 also passed (Debug messages are enabled):
|
ok, maybe my board issue atagin. |
Hi @d3zd3z , PR is waiting for you. |