Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arooj #3192

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Arooj #3192

wants to merge 2 commits into from

Conversation

arooj-12
Copy link

No description provided.

Copy link

🙏 Thanks for your pull request @arooj-12, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
3192 33 1
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 1059 2839

@sophiabrandt
Copy link
Member

Please only add one file with your name/submission @arooj-12

Copy link

🙏 Thanks for your pull request @arooj-12, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
3192 33 1
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 1060 2846

@sophiabrandt
Copy link
Member

@arooj-12 are you still interested in this PR?

@arooj-12
Copy link
Author

arooj-12 commented May 5, 2024 via email

@sophiabrandt
Copy link
Member

@arooj-12 As you can see in the files tab on this page there are changes to 3 files. Please fix that, otherwise we cannot accept your pull request.

@majidshakeelshawl
Copy link
Contributor

majidshakeelshawl commented May 13, 2024

Hi @arooj-12, I think you are getting confused with the requested changes, actually the reviewer is asking you to do the following changes:

  • UNDO the changes in the 0ifechukwu-daniel.json as the file belongs to someone else.
  • DELETE the other 1-arooj.json file as it doesn't match with your github username.

NOTES

  1. Only keep one file i.e. arooj-12.json .
  2. Don't add or remove or even change anything else other than arooj-12.json .

@sophiabrandt
Copy link
Member

@arooj-12 Hey, just letting you know that I'm going to close your PR in a few days.
If you do not want to go through the work of making the requested changes, it might be easier to start fresh with a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants