zloop: ignore EINTR from poll if nonstop is enabled #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to CI it seems like MacOS is not happy with the way I try to test this. I'll try to figure out why. |
If SIGINT signal arrives while poll is blocking, regardless of attached signal handler it will cause the poll to return with errno EINTR. Currently, this causes zloop to return from the event loop. For nonstop mode to work as intended, we have to ignore EINTR in this case. Added test cases that verify the functionality when catching an actual SIGINT signal with and without nonstop mode. Tested in Linux and Windows.
oko256
force-pushed
the
zloop-fix-nonstop
branch
from
d9a4787
to
3a38d94
Compare
On macOS, in zsock STREAM test, when STREAM zsock was bound with `tcp://*:*`, the respective connect to `tcp://127.0.0.1:<port>` was unable to connect and got stuck indefinitely. Fixed by binding to `tcp://127.0.0.1:*` instead like in other tests in zsock.
|
The zloop macOS test issue was just too strict timing requirement on the test, so I relaxed those requirements a bit and now it passes nicely. The functionality itself was working just fine. I also noticed that zsock tests have been failing apparently for some time on macOS, so I fixed that issue as well: other tests in zsock bind to |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If SIGINT signal arrives while poll is blocking, regardless of attached signal handler it will cause the poll to return with errno EINTR. Currently, this causes zloop to return from the event loop. For nonstop mode to work as intended, we have to ignore EINTR in this case.
Added test cases that verify the functionality when catching an actual SIGINT signal with and without nonstop mode. Tested in Linux and Windows.
Fixes #2284