Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not bundle zmq.hpp in Debian packages anymore #4687

Closed

Conversation

stephanlachnit
Copy link
Contributor

This reverts commit 83c042c from #2852.

Starting with Debian 12 and Ubuntu 23.04, zmq.hpp is now included in the cppzmq-dev package. Thus, zmq.hpp should be removed from the OBS packages to prevent a conflict with the system cppzmq pacakge.

This reverts commit 83c042c.

Starting with Debian 12 and Ubuntu 23.04, zmq.hpp is now included in the
cppzmq-dev package. Thus, zmq.hpp should be removed from the OBS packages
to prevent a conflict with the system cppzmq pacakge.
@bluca
Copy link
Member

bluca commented May 10, 2024

It really makes no sense to have a separate package for a header, but whatever. The point of this is to provide latest git content, so instead please just add a conflict+replaces.

@stephanlachnit
Copy link
Contributor Author

stephanlachnit commented May 10, 2024

It really makes no sense to have a separate package for a header, but whatever. The point of this is to provide latest git content, so instead please just add a conflict+replaces.

Yes and no. It is not actually about the header, but detecting cppzmq via pkg-config/cmake, which gets annoying when debian/ubuntu just ships it as part of libzmq and the rest doesn't. The conflict+replaces is in the cppzmq-dev package is actually there, we can't conflict+replaces OBS packages. And the OBS package shouldn't conflit+replace cppzmq since it doesn't provide the pkg-config/cmake detection files.

I also disagree about the point of the OBS packages: cppzmq is developed separately which a separate repo and separate releases, so the only reason to put zmp.hpp in the libzmq OBS package is to mimic the (now former) Debian package decision. This was also the reasoning when this was introduced in #2852.

@bluca
Copy link
Member

bluca commented May 10, 2024

Nah, it's in the same OBS repo as it's a pain to maintain, so it makes it easier. Just add the conflict+replace here and that will solve the problem.

@stephanlachnit
Copy link
Contributor Author

Nah, it's in the same OBS repo as it's a pain to maintain, so it makes it easier. Just add the conflict+replace here and that will solve the problem.

No, it won't. Only if the cppzmq.pc file is also installed, otherwise it is useless (except if you only target Debian). Besides, I can still use system cppzmq (which hasn't seen changes in a while anyway) with OBS draft libzmq.

@stephanlachnit
Copy link
Contributor Author

@bluca can we please merge this? This just mirror the behavior of the rpm packages on OBS, which also don't have the zmq.hpp file.

@bluca
Copy link
Member

bluca commented May 15, 2024

No - as mentioned, add conflicts and replaces instead

@stephanlachnit
Copy link
Contributor Author

Alright, then I will close this since just adding conflict and replaces will not solve my issue with the deb OBS packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants