Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing magic numbers from color generator #34

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TornaxO7
Copy link

@TornaxO7 TornaxO7 commented Jun 16, 2022

I'd like to change the constant numbers with constant variable names to make it easier to understand those constant numbers in the color generator. But I don't fully understand what your calculations are doing here:

Could you please explain them a bit and do you agree to move those constants to variables/(named) constants?

@TornaxO7 TornaxO7 marked this pull request as draft June 16, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant