Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Scala Version #7377

Merged
merged 12 commits into from Oct 26, 2022
Merged

Update Scala Version #7377

merged 12 commits into from Oct 26, 2022

Conversation

adamgfraser
Copy link
Contributor

Resolves #7376.

vigoo
vigoo previously approved these changes Sep 29, 2022
View reviewed changes
Wosin
Wosin previously approved these changes Sep 29, 2022
View reviewed changes
@adamgfraser adamgfraser dismissed stale reviews from Wosin and vigoo via d4880f5 September 29, 2022 22:27
@narma
Copy link
Contributor

narma commented Sep 30, 2022 •
edited

Looks like we should wait for 2.13.10 -

@adamgfraser adamgfraser mentioned this pull request Oct 8, 2022
Closed
@sideeffffect
Copy link
Member

sideeffffect commented Oct 9, 2022 •
edited

The 2.13.10 release is rolling out now. AFAIK we just need to wait for Silencer ( https://repo1.maven.org/maven2/com/github/ghik/silencer-lib_2.13.10/ ) and then we can upgrade too 🤞
EDIT: relevant ticket ghik/silencer#77

@sideeffffect
Copy link
Member

@adamgfraser new Silencer for 2.13.10 has been released. We can now upgrade to 2.13.10, Silencer 1.7.12.

Maybe we won't need all the changes to the code with 2.13.10 (unlike with 2.13.9).

sideeffffect
sideeffffect suggested changes Oct 21, 2022
View reviewed changes
Copy link
Member

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://repo1.maven.org/maven2/ch/epfl/scala/scalafix-testkit_2.13.10/

project/plugins.sbt Outdated
@@ -15,6 +15,6 @@ addSbtPlugin("org.scalameta" % "sbt-mdoc"
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.6")
addSbtPlugin("pl.project13.scala" % "sbt-jcstress" % "0.2.0")
addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.4.3")
addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.10.1")
addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.10.3")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be updated to 0.10.4

build.sbt Outdated
@@ -764,7 +764,7 @@ lazy val scalafixRules = project.module
.settings(
scalafixSettings,
semanticdbEnabled := true, // enable SemanticDB
libraryDependencies += "ch.epfl.scala" %% "scalafix-core" % "0.10.1"
libraryDependencies += "ch.epfl.scala" %% "scalafix-core" % "0.10.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be updated to 0.10.4

sideeffffect
sideeffffect reviewed Oct 22, 2022
View reviewed changes
project/plugins.sbt Outdated Show resolved Hide resolved
@sideeffffect
Copy link
Member

sideeffffect commented Oct 23, 2022 •
edited

All tests green 🎉
Better to use Squash merge in this case 😉

@sideeffffect
Copy link
Member

@adamgfraser @mijicd ping 😸

@mijicd mijicd merged commit 6f43e52 into zio:series/2.x Oct 26, 2022
@adamgfraser adamgfraser deleted the version branch November 3, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideeffffect sideeffffect sideeffffect requested changes

@mijicd mijicd mijicd approved these changes

@Wosin Wosin Wosin left review comments

@iravid iravid Awaiting requested review from iravid

@vigoo vigoo Awaiting requested review from vigoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shall we add support for scala 2.13.9?
6 participants
@adamgfraser @narma @sideeffffect @vigoo @mijicd @Wosin