To fix? #8771
Draft
To fix? #8771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegoes
reviewed
Apr 20, 2024
| // 5. which would mean that this `(k ne FiberRuntime.notBlockingOn)` test is useless | ||
| // Some questions to answer then: | ||
| // 1. Why and when was it added? | ||
| // 2. If it's indeed incorrect/useless, should it be removed or replaced with something else? What was the intention of the original author? | ||
| if ((k ne null) && (k ne FiberRuntime.notBlockingOn)) { |
There was a problem hiding this comment.
I think it's useless and can be removed. Maybe it was part of my work in (high-perfomrantly) integrating blocking into ZIO's Loom support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for someone to explore the TODO and the questions I added in the code 馃檪