fix: removed diff rendering from the assertion

[varshith257]

• Fixes zio-test: classic assertion equalTo using Diff #8664
• /claim zio-test: classic assertion equalTo using Diff #8664

Changes Made:

1. Updated the rendering logic to occur outside the assertion function, enabling a more modular architecture for code reuse and alternate renderings.

[CLAassistant]

All committers have signed the CLA.

[algora-pbc]

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay.

[varshith257]

@ghostdogpr This PR aims to unify rendering logic to SmartAssertions and ordinary assertions to ensure code reusability. But when the renderdiff is applied to ordinary assertions equalTo function, CI fails with type errors.
Any guidance here?

[varshith257]

@ghostdogpr This PR aims to unify rendering logic to SmartAssertions and ordinary assertions to ensure code reusability. But when the renderdiff is applied to ordinary assertions equalTo function, CI fails with type errors. Any guidance here?

cc : @kyri-petrou

[varshith257]

@ghostdogpr This PR aims to unify rendering logic to SmartAssertions and ordinary assertions to ensure code reusability. But when the renderdiff is applied to ordinary assertions equalTo function, CI fails with type errors. Any guidance here?

cc/ @ghostdogpr

[ghostdogpr]

It doesn't compile because Diff[A] can only compare 2 values of type A but here we are comparing A and B which are different types. The existing code is using diffProduct which infers the objects to be Any so it can compare anything.

[varshith257]

It doesn't compile because Diff[A] can only compare 2 values of type A but here we are comparing A and B which are different types. The existing code is using diffProduct which infers the objects to be Any so it can compare anything.

It mean can't we unify this diff rendering to both ordinary and smart assertions?

Or

Any typecast is required?

[ghostdogpr]

Maybe we can change equalTo to return an Assertion[A], that way you can use Diff[A]. I wonder if there are cases where type inference won't work when B is a subtype of A but maybe it's okay to explicitly use type parameters in that case.

[varshith257]

Maybe we can change equalTo to return an Assertion[A], that way you can use Diff[A]. I wonder if there are cases where type inference won't work when B is a subtype of A but maybe it's okay to explicitly use type parameters in that case.

@ghostdogpr This approach making large no of tests flaky to fail. After my trial and error with this equalTo functions of both SmartAssertions and ordinary, I suscept we can't unify the rendering of diff function.

Waiting for your final review

[ghostdogpr]

I believe the compile errors are because you changed OptionalImplicit[Diff[A]] to Diff[A]. I don't think this should be changed.

[varshith257]

@ghostdogpr The changes made to ordinary assertion to unify the same renderdiff of smartAssertions led to fail large chunks of test.

[varshith257]

@jdegoes @ghostdogpr It's making it hard to use the same render diff logic to both smartAssertions and ordinaryAssertions as they behave differently with their input args. You'll be able to verify through my commits. I have been experimenting with it for a while and it's nearly 60 commits.

Waiting for your guidance to solve/alter approaches

[varshith257]

The failing test is of ordinary Assertions changed behavior emitting test fails except lint workflow

[varshith257]

@ghostdogpr PTAL

[ghostdogpr]

I don't have anything better to suggest at the moment 😄

[varshith257]

@varshith257 This does not really fix the problem. It reorganizes the diff rendering code, but does not unify it between smart assertions and ordinary assertions.

I don't have anything better to suggest at the moment 😄

@jdegoes It's for your review now