Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): init events #7823

Merged
merged 33 commits into from
May 23, 2024
Merged

refactor(v2): init events #7823

merged 33 commits into from
May 23, 2024

Conversation

adlerhurst
Copy link
Member

@adlerhurst adlerhurst commented Apr 22, 2024

these events are used for later PRs.

This PR includes the changes of #7806 merge the successor first before you start reviewing this PR.

Part of #7639

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 8:41pm

@adlerhurst adlerhurst requested a review from livio-a April 22, 2024 13:24
@adlerhurst adlerhurst self-assigned this Apr 22, 2024
@adlerhurst adlerhurst changed the base branch from internal-v2-database to main April 22, 2024 13:25
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 4.27509% with 515 lines in your changes are missing coverage. Please review.

Project coverage is 62.19%. Comparing base (f371131) to head (6dc7bc2).

Files Patch % Lines
internal/v2/org/domain.go 0.00% 48 Missing ⚠️
internal/v2/org/domain_policy.go 0.00% 36 Missing ⚠️
internal/v2/org/added.go 0.00% 28 Missing ⚠️
internal/v2/instance/domain_policy.go 0.00% 24 Missing ⚠️
internal/v2/user/human_avatar.go 0.00% 24 Missing ⚠️
internal/v2/eventstore/postgres/event.go 30.00% 13 Missing and 1 partial ⚠️
internal/v2/org/state.go 0.00% 14 Missing ⚠️
internal/v2/eventstore/event.go 0.00% 12 Missing ⚠️
internal/v2/org/changed.go 0.00% 12 Missing ⚠️
internal/v2/user/domain_claimed.go 0.00% 12 Missing ⚠️
... and 34 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7823      +/-   ##
==========================================
- Coverage   62.46%   62.19%   -0.28%     
==========================================
  Files        1342     1379      +37     
  Lines      110863   111348     +485     
==========================================
- Hits        69252    69250       -2     
- Misses      37730    38214     +484     
- Partials     3881     3884       +3     
Flag Coverage Δ
core-integration-tests-postgres 62.19% <4.27%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adlerhurst adlerhurst marked this pull request as ready for review April 26, 2024 15:07
@adlerhurst adlerhurst enabled auto-merge (squash) April 26, 2024 15:07
@adlerhurst adlerhurst enabled auto-merge (squash) April 26, 2024 15:07
internal/v2/avatar/added.go Show resolved Hide resolved
internal/v2/org/aggregate.go Show resolved Hide resolved
internal/v2/org/changed.go Outdated Show resolved Hide resolved
internal/v2/org/state.go Show resolved Hide resolved
internal/v2/org/added.go Outdated Show resolved Hide resolved
internal/v2/user/human_registered.go Outdated Show resolved Hide resolved
internal/v2/user/machine_secret_set.go Outdated Show resolved Hide resolved
internal/v2/user/human_init_code_added.go Outdated Show resolved Hide resolved
internal/v2/user/human_password_changed.go Outdated Show resolved Hide resolved
internal/v2/user/token_added.go Outdated Show resolved Hide resolved
livio-a
livio-a previously approved these changes May 22, 2024
@adlerhurst adlerhurst merged commit 12be21a into main May 23, 2024
25 of 27 checks passed
@adlerhurst adlerhurst deleted the internal-v2-events branch May 23, 2024 04:36
Copy link

🎉 This PR is included in version 2.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants