Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update fr translations #7910

Merged
merged 6 commits into from
May 17, 2024
Merged

fix: Update fr translations #7910

merged 6 commits into from
May 17, 2024

Conversation

Aurel004
Copy link
Contributor

@Aurel004 Aurel004 commented May 5, 2024

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Hi,

This is just an update of the french translations found in the code. It might not be perfect but better than before. It seems like sometimes it was auto-translated without context and many capital letters were missing (a bit awful sometimes)

Thank you

Copy link

vercel bot commented May 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 9:37am

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label May 5, 2024
@Aurel004 Aurel004 changed the title Update fr translations Updating fr translations May 5, 2024
@Aurel004 Aurel004 changed the title Updating fr translations fix: Update fr translations May 5, 2024
peintnermax
peintnermax previously approved these changes May 7, 2024
Copy link
Member

@peintnermax peintnermax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @Aurel004 for your contribution 🙏

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.75%. Comparing base (b924fd5) to head (21abe07).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7910   +/-   ##
=======================================
  Coverage   62.75%   62.75%           
=======================================
  Files        1341     1341           
  Lines      111033   111033           
=======================================
  Hits        69679    69679           
- Misses      37427    37429    +2     
+ Partials     3927     3925    -2     
Flag Coverage Δ
core-integration-tests-postgres 62.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peintnermax peintnermax merged commit 6858ed7 into zitadel:main May 17, 2024
26 checks passed
Copy link

🎉 This PR is included in version 2.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants