Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in the fr translation file for login ui sms otp mfa #7946

Merged
merged 1 commit into from
May 14, 2024

Conversation

JayPe69
Copy link
Contributor

@JayPe69 JayPe69 commented May 14, 2024

Which Problems Are Solved

SMS OTP MFA translations are not displayed in FR language on the login ui

How the Problems Are Solved

By changing the typo in the FR translation file

Additional Changes

Additional Context

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:54am

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label May 14, 2024
@hifabienne hifabienne changed the title fix typo in the fr translation file for login ui sms otp mfa fix: typo in the fr translation file for login ui sms otp mfa May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.09%. Comparing base (0e9ebed) to head (77962e4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7946      +/-   ##
==========================================
- Coverage   63.09%   63.09%   -0.01%     
==========================================
  Files        1335     1335              
  Lines      110671   110671              
==========================================
- Hits        69829    69825       -4     
- Misses      36874    36878       +4     
  Partials     3968     3968              
Flag Coverage Δ
core-integration-tests-postgres 63.09% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hifabienne hifabienne merged commit e029b2c into zitadel:main May 14, 2024
27 of 29 checks passed
@JayPe69 JayPe69 deleted the fix-fr-smsotpmfa-translations branch May 17, 2024 07:23
Copy link

🎉 This PR is included in version 2.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: SMSOTPMFA translation in login ui not displayed
2 participants