Add caused_by to Diagnostic #165
Conversation
|
For me, tests are green now 🎉 |
|
Thanks for the patch and the fixes so far! I've continued thinking about this and I'm wondering: How would you feel about renaming |
|
Definitively. Tell me if there's more that you want to have changed. I'll make sure to squash the history appropriately before it gets merged, if it gets merged. |
Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "miette" | |||
| version = "4.6.1-alpha.0" | |||
| version = "4.4.8" | |||
There was a problem hiding this comment.
I think this should not be in the commit
| std::option::Option::Some(self.#rel.as_ref()) | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
uhhh, this shouldn't be unused.
The gen_struct typically generates definitions for when the macro is used on a struct-style error, for example:
#[derive(Diagnostic, Error)]
#[error("meh")]
struct MyError {
#[diagnostic_source]
src: SomeError
}
|
Okay, I guess now this looks like it is ready ... @zkat if you agree, I can squash and make the history here pretty before it goes in! |
|
you'll want all the tests passing first :) |
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
|
yay! Thanks again! :) Looks like we're all set~ |
Hi!
Currently, miette does not support error causes which contain a
Diagnostic.This draft tries to change that. It is related to #164 , as I worked with @TheNeikos on implementing this.
Tell me what you think! ❤️
Please note that I will rebase this PR until we all agree on a way forward!