Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] integration test for mac #370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[chore] integration test for mac #370

wants to merge 1 commit into from

Conversation

tkmct
Copy link
Contributor

@tkmct tkmct commented Jan 31, 2022

on macos, I could run integration tests by applying following configs. but this might break other os.

@wanseob
Copy link
Member

wanseob commented Feb 15, 2022

I hope we can add some conditions like
getContainer returns 0.0.0.0 when the os is macos. I think we can refer this doc https://nodejs.org/api/process.html#process_process_platform

@cloudinertia
Copy link

i agree with wanseob's comment. we can make this works for more general situation

@tkmct
Copy link
Contributor Author

tkmct commented Feb 21, 2022

okay, I'll work on that. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants