Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-js-builder: Allow webpack 5 and modernize code #1227

Closed
wants to merge 1 commit into from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 23, 2023

Current node LTS 14.x is already about to be EOL, so it should be safe to update the minimum node version to at least 12.x
This allows to modernize the code and get rid of a dependency (mkdirp).

Also allow using webpack 5 to fix issues reported by npm audit when using the core-js-builder:

6 high severity vulnerabilities

# npm audit report

glob-parent  <5.1.2
Severity: high
glob-parent before 5.1.2 vulnerable to Regular Expression Denial of Service in enclosure regex - https://github.com/advisories/GHSA-ww39-953v-wcq6
fix available via `npm audit fix --force`
Will install core-js-builder@3.6.5, which is a breaking change
node_modules/watchpack-chokidar2/node_modules/glob-parent
  chokidar  1.0.0-rc1 - 2.1.8
  Depends on vulnerable versions of glob-parent
  node_modules/watchpack-chokidar2/node_modules/chokidar
    watchpack-chokidar2  *
    Depends on vulnerable versions of chokidar
    node_modules/watchpack-chokidar2
      watchpack  1.7.2 - 1.7.5
      Depends on vulnerable versions of watchpack-chokidar2
      node_modules/watchpack
        webpack  4.44.0 - 4.46.0
        Depends on vulnerable versions of watchpack
        node_modules/webpack
          core-js-builder  >=3.7.0
          Depends on vulnerable versions of webpack

With this PR: found 0 vulnerabilities

…ow modern code

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@zloirock
Copy link
Owner

zloirock commented Mar 23, 2023

Sorry, I can't accept it - core-js-builder@3 should support NodeJS 8 even after EOL, otherwise, it's a breaking change. Anyway, I wanna start active work on core-js@4 with tooling soon where such dependencies will be updated / replaced / removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants