Allow for individual lints to opt-out of the ZLint framework executing pre-flight applicability rules #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopher-henderson
force-pushed
the
fix_ocsp
branch
from
0c5c9b2
to
f0455f6
Compare
| @@ -74,11 +74,11 @@ func TestOCSPIDPKIXOCSPNocheckExtNotIncludedServerAuth(t *testing.T) { | |||
| }, { | |||
| Name: "o1s0ep0a0nc0", | |||
| Filename: "o1s0ep0a0nc0.pem", | |||
| ExpectedResult: lint.NA, | |||
There was a problem hiding this comment.
These are tests certs that do not have server auth, so they now apply.
christopher-henderson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #838
The core issue here was CABF places requirements, by-and-large, on server certificates. Thus, the framework did a kindness to CABF lints by baking in a pre-flight
IsServerAuthcheck for all CABF lints.This however, precluded that ability to lint certificates that are governed by CABF, but are not themselves server certificates. A prime example is
v3/lints/cabf_br/lint_ocsp_id_pkix_ocsp_nocheck_ext_not_included_server_auth.gowhich is a CABF requirement placed on OCSP signing certificates.As such, we would like for individual lints to be able to opt out of the framework's pre-flight applicability rules when necessary.w
Thank you @defacto64 for reporting the issue and thank you to @toddgaunt-gs for the cleaner boolean flag idea (I had forgotten that we had concrete structs available to us, rather than just interfaces that lints implement).