refactor(classifier): survey task Choice model

[eatyourgreens]

Add a Choice model to the survey task. Model choices as a Map of Choice types, mapped by choice ID. Update the tests where they were testing a task snapshot rather than a task model.

Please request review from @zooniverse/frontend team or an individual member of that team.

Package

• lib-classifier/plugins/tasks/survey

Linked Issue and/or Talk Post

• fix(classifier): surveyTask.alwaysShowThumbnails must be a boolean #6085
• refactor(classifier): use a map for survey task characteristics #6086

Similar to #6086, this refactors task.choices to use types.map(Choice) , rather than types.frozen({}).

How to Review

I used the storybook to test the changes here. Snapshot Wisconsin (project slug zooniverse/snapshot-wisconsin) is also useful for checking if a survey task works.

https://localhost:8080/?project=zooniverse/snapshot-wisconsin&env=production

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

• Tests are passing locally and on Github
• Documentation is up to date and changelog has been updated if appropriate
• You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
• FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
• FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

• All pages of a FEM project load: Home Page, Classify Page, and About Pages
• Can submit a classification
• Can sign-in and sign-out
• The component is accessible
  • Can be used with a screen reader BBC guide to VoiceOver
  • Can be used from the keyboard WebAIM guide to keyboard testing
  • It is passing accessibility checks in the storybook.

Refactoring

• The PR creator has described the reason for refactoring
• The refactored component(s) continue to work as expected

[coveralls]

coverage: 79.281% (-0.04%) from 79.323%
when pulling d4cb448 on eatyourgreens:refactor-survey-task-choices
into 9a7a630 on zooniverse:master.