Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(classifier): reset hidden marks when the subject changes #6098

Merged

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented May 18, 2024

Reset the Hide Previous Marks toggle when a drawing task is reset. This should fix a bug where task.hidingIndex is remembered across subjects, which means that a volunteer won't see the first few marks that they draw on a new subject.

That affects both drawing and transcription tasks, as both use the same code to store task.hidingIndex across subjects.

Screen.Recording.2024-05-18.at.11.15.46.mov

Please request review from @zooniverse/frontend team or an individual member of that team.

Package

  • lib-classifier/plugins/tasks/drawing
  • lib-classifier/plugins/tasks/experimental/transcription

Linked Issue and/or Talk Post

How to Review

You can test this on WildWatch Burrowing Owl. See the video above.
https://localhost:8080/?project=sandiegozooglobal/wildwatch-burrowing-owls&env=production&demo=true

Checking a transcription workflow would also be a good idea, as the same code is used by both transcription and drawing tasks. I’ve included tests for both tasks in this PR.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

Bug Fix

  • The PR creator has listed user actions to use when testing if bug is fixed
  • The bug is fixed
  • Unit tests are added or updated

@coveralls
Copy link

coveralls commented May 18, 2024

Coverage Status

coverage: 80.383% (-0.01%) from 80.397%
when pulling 0611eb2 on eatyourgreens:fix-reset-hidden-marks
into 59d5240 on zooniverse:master.

Reset the Hide Previous Marks toggle when the a drawing task is reset. This should fix a bug where `task.hidingIndex` is remembered across subjects, which means that a volunteer won't see the first few marks that they draw on a new subject.
Copy link
Contributor

@goplayoutside3 goplayoutside3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you!

@goplayoutside3 goplayoutside3 merged commit d18c20b into zooniverse:master May 23, 2024
8 checks passed
@eatyourgreens eatyourgreens deleted the fix-reset-hidden-marks branch May 23, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide previous marks persists to next subject, but will show 2nd mark
3 participants