Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move project .npmrc out of the way for publish #63

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

t1m0thyj
Copy link
Contributor

@t1m0thyj t1m0thyj commented Jun 9, 2022

The quick hack to get zowe/imperative#838 published yesterday was to pass --@zowe:registry on the publish and dist-tag commands rather than just --registry.

But having to do this on all our NPM commands seems kind of annoying. This PR moves the project .npmrc file out of the way during the publish operation, similar to how zowe-cli-version-controller does it 馃檪

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj requested a review from zFernand0 June 9, 2022 14:22
Copy link
Collaborator

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this without whitespaces made it easier 馃構
LGTM!

packages/npm/src/utils.ts Show resolved Hide resolved
packages/npm/src/publish.ts Show resolved Hide resolved
dist/npm.js Show resolved Hide resolved
@t1m0thyj t1m0thyj merged commit 0aa583a into master Jun 9, 2022
@t1m0thyj t1m0thyj deleted the fix-npm-publish-registry branch June 9, 2022 15:41
@github-actions
Copy link

Release succeeded for the master branch. 馃帀

The following packages have been published:

Powered by Octorelease 馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants