fix/dev(v1): Fix gulp build tasks failing on Windows #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
|
gejohnston
approved these changes
May 6, 2024
t1m0thyj
added
the
release-current
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Fixes gulp build tasks that invoke
npm.cmdon Windows (see failing build here)For details about why they broke in Node 20.12.2, see https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2
The
shell: trueis not best practices for security, but it's the easiest workaround and I think it's fine in v1-only dev scripts where we were already using it.How to Test
If using Windows, upgrade to Node 20.12.2 or newer and verify that the zowe-v1-lts branch is able to build successfully with these changes
Review Checklist
I certify that I have:
Additional Comments
.cmd/.batfiles on Windows (EINVAL) sindresorhus/execa#987