Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject superfluous trailing characters after keywords #91

Merged
merged 2 commits into from Sep 8, 2021
Merged

Reject superfluous trailing characters after keywords #91

merged 2 commits into from Sep 8, 2021

Conversation

nickelc
Copy link
Contributor

@nickelc nickelc commented Sep 8, 2021

fixes: #86

zslayton
zslayton requested changes Sep 8, 2021
View reviewed changes
Copy link
Owner

@zslayton zslayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! Some superficial requests below.

tests/issues.rs Outdated Show resolved Hide resolved
@zslayton zslayton merged commit 883780c into zslayton:master Sep 8, 2021
@nickelc nickelc deleted the issue_86 branch September 8, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zslayton zslayton zslayton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrectly parses shorthand with suffix e.g. "@dailyBla"
2 participants
@nickelc @zslayton