Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Homebrew install instructions #65

Open
wants to merge 55 commits into
base: master
Choose a base branch
from
Open

Add Homebrew install instructions #65

wants to merge 55 commits into from

Conversation

danielbayley
Copy link

@danielbayley danielbayley commented Feb 9, 2023 •
edited

zthxxx and others added 30 commits April 10, 2020 23:22
@zthxxx
feat: update record script, re-render pictures
9228569
@zthxxx
fix: fix preformance of scroll up
cf2b250
@zthxxx
perf: throttle render() for combo and paste
d982c12
@zthxxx
fix: remove useless metadata file, due to uninstall will not remove it
74b1f95
@zthxxx
perf: 10k lines history loading 79ms to 49ms
32d2f20
@zthxxx
perf: add benchmark scripts
987b44c
@zthxxx
fix: fix mock read tty in ci test
dfe40da
@zthxxx
perf: make choices to string array, benchmark 500ms to 230ms
a60dc3c
@zthxxx
fix: fix build and strip signale
0c55458
@zthxxx
test: refactor unit tests, add more case
86fbf0a
@zthxxx
fix: fix scroll calculate according to unit test
e27f5c8
@zthxxx
fix: fix submit with init input, refactor clear and restore function
88f0ea9
@zthxxx
fix: fix page up/down when empty choice
172688b
@zthxxx
chore: replace to @rollup/plugin-typescript while it support strip
4b85642
@zthxxx
ci(renovate): update renovate schedule config
1ccb9a5
@renovate-bot
Add renovate.json
e09e83e
@zthxxx
Merge pull request zthxxx#6 from zthxxx/renovate/configure
956e6d3 
Configure Renovate
@renovate-bot
chore(deps): pin dependencies
0d54392
@zthxxx
Merge pull request zthxxx#11 from zthxxx/renovate/pin-dependencies
6e12faa 
chore(deps): pin dependencies
@zthxxx
ci(renovate): update renovate config
f12800d
@zthxxx
ci(renovate): refactor renovate schedule via github action
95cb2e8
@renovate-bot @zthxxx
chore(deps): update all non-major dependencies
b08335d
@renovate-bot
chore(deps): update all non-major dependencies
078bbb3
@zthxxx
Merge pull request zthxxx#30 from zthxxx/renovate/all-minor-patch
d7f69ec 
chore(deps): update all non-major dependencies
@zthxxx
chore: add some trace for install
b5eac6f
@renovate-bot
chore(deps): update all non-major dependencies
5398125
@renovate-bot
chore(deps): update dependency execa to v5
a5462e4
@zthxxx
Merge pull request zthxxx#31 from zthxxx/renovate/all-minor-patch
20a69ab 
chore(deps): update all non-major dependencies
@zthxxx
Merge pull request zthxxx#28 from zthxxx/renovate/execa-5.x
0eb4de5 
chore(deps): update dependency execa to v5
@renovate-bot
chore(deps): update all non-major dependencies
c6e2bd7
zthxxx and others added 23 commits June 29, 2021 15:11
@zthxxx
Merge pull request zthxxx#36 from zthxxx/renovate/all-minor-patch
013b2f8 
chore(deps): update all non-major dependencies
@renovate-bot
chore(deps): update all non-major dependencies
8c6c497
@zthxxx
Merge pull request zthxxx#37 from zthxxx/renovate/all-minor-patch
6134513 
chore(deps): update all non-major dependencies
@zthxxx
chore(deps): update dependencies
9c9e8d5
@zthxxx
chore: complete benchmark scripts
bc1515c
@zthxxx
fix: block invalid keyboard input, like Ctrl+D Alt+B
7550561
@renovate-bot
chore(deps): update all non-major dependencies
ee564b1
@renovate-bot
chore(deps): update dependency @rollup/plugin-commonjs to v21
8c64aaf
@zthxxx
Merge pull request zthxxx#41 from zthxxx/renovate/all-minor-patch
350c165 
chore(deps): update all non-major dependencies
@zthxxx
Merge pull request zthxxx#43 from zthxxx/renovate/rollup-plugin-commo…
8e15591 
…njs-21.x

chore(deps): update dependency @rollup/plugin-commonjs to v21
@zthxxx
chore: clean config files
ec14880
@zthxxx
chore: update installer with more compatibility with detect node env
b355e20
@zthxxx
fix: fix install script for .zshrc as symlink
a0ced2f
@zthxxx
ci: refactor and reuse github actions steps
6e0c9ff
@renovate-bot
chore(deps): update all non-major dependencies
709ed02
@zthxxx
Merge pull request zthxxx#45 from zthxxx/renovate/all-minor-patch
ebc3b8a 
chore(deps): update all non-major dependencies
@zthxxx
chore: release v1.2.5, update all non-major dependencies
da785ee
@renovate-bot
chore(deps): update all non-major dependencies
f755288
@zthxxx
Merge pull request zthxxx#51 from zthxxx/renovate/all-minor-patch
e071fa9 
chore(deps): update all non-major dependencies
@renovate-bot
chore(deps): update all non-major dependencies
865d177
@zthxxx
Merge pull request zthxxx#52 from zthxxx/renovate/all-minor-patch
e269d50 
chore(deps): update all non-major dependencies
@zthxxx
feat: support install by antigen, remove doc on obsolete `unsafe-perm…
db717e0 
…` flag
@danielbayley
Add Homebrew install instructions
7398b08 
Pending Homebrew/homebrew-core#122728
@zthxxx
Copy link
Owner

zthxxx commented May 25, 2023

@danielbayley I apologize for the delay. 😵‍💫

I'd like to assist in resolving the issue with the brew formula. How can I gain access to this Pull Request Homebrew/homebrew-core#122728 ?

Alternatively, would it be more appropriate for me to open a new Pull Request?

@zthxxx
Copy link
Owner

zthxxx commented Jun 1, 2023

I'm sad that I had to close this PR due to the related PR in Homebrew/homebrew-core#122728 was closed.

@zthxxx zthxxx closed this Jun 1, 2023
@danielbayley
Copy link
Author

Alternatively, would it be more appropriate for me to open a new Pull Request?

@zthxxx I can just submit another PR with the same formula…

I'd like to assist in resolving the issue with the brew formula.

looks like just linux test failure?

The problem seems to be just with the brew test only on Linux. I don’t have that environment setup to test on currently, do you? @zthxxx You should reopen this PR…

@danielbayley
Copy link
Author

danielbayley commented Nov 15, 2023 •
edited

I'm sad that I had to close this PR due to the related PR in Homebrew/homebrew-core#122728 was closed.

@zthxxx I have reopened this in Homebrew/homebrew-core#154416. Could you figure out why the test was not passing on Linux?

Also, please reopen this PR, rather than create another one…

@zthxxx zthxxx reopened this Nov 19, 2023
@zthxxx
Copy link
Owner

zthxxx commented Nov 19, 2023

Thank your very much for your work. Do to the conflicts, I plan to just pick your commit 7398b08 and force-push it onto your PR branch danielbayley:patch-1 after I have deal with Homebrew/homebrew-core#154416 next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielbayley @zthxxx @renovate-bot