Fix default path set to '.' #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztoben
requested changes
Dec 2, 2020
|
Currently it uses the value of assets-webpack-plugin/index.js Line 39 in cdfb655 |
|
Oh shoot, yeah you're right I forgot about that. Your change looks good then other than you should change the references from |
ztoben
reviewed
Dec 2, 2020
index.js
Outdated
| @@ -39,6 +38,7 @@ AssetsWebpackPlugin.prototype = { | |||
| ? (compiler.options.output.path || '.') | |||
| : (self.options.path || '.') | |||
| ) | |||
| this.writer = createQueuedWriter(createOutputWriter(this.options)) | |||
There was a problem hiding this comment.
Suggested change
| this.writer = createQueuedWriter(createOutputWriter(this.options)) | |
| self.writer = createQueuedWriter(createOutputWriter(self.options)) |
The documentation says the default path is '.', however, without this fix, by the time createOutputWriter was called, options.path was null and the attempt to create the output directory would fail.
|
Okay, I've updated to use |
ztoben
approved these changes
Dec 2, 2020
|
@rosenfeld should be available in |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation says the default path is '.', however, without this fix,
by the time createOutputWriter was called, options.path was null and
the attempt to create the output directory would fail.