SwitchAccountButton: Remove unused prop accounts.

[jackrzhang]

This is a silent type error that seems to have been introduced via b37352a#diff-73a6ef41677e3bf406fce93366e99735.

[borisyankov]

Nice. Is there a way to make these errors non-silent?

[jackrzhang]

There is a react/no-unused-prop-types eslint rule, but that seems to be specific to the syntax React.propTypes and not flow.

(hm, still looking around...)

[jackrzhang]

According to jsx-eslint/eslint-plugin-react#1412, this should be supported. Maybe there's something that's not being done with the eslint configuration?

[borisyankov]

Possible. We did turn off some Flow and ESLint configurations.
If you are curious you can try turning on some of these offs here:
https://github.com/zulip/zulip-mobile/blob/master/.eslintrc.yaml

[gnprice]

Thanks @jackrzhang ! Merged.

I share @borisyankov 's reaction 🙂 -- it would be great to have this automatically checked. I played with it a bit just now, but didn't find a way; in particular, making that Props an exact type was no help. I suspect unfortunately a Flow-based approach won't be helpful until connect has more of a real-type signature:

  declare export function connect<
    Com: ComponentType<*>,
    S: Object,
    SP: Object,
    RSP: Object,
    CP: $Diff<OmitDispatch<ElementConfig<Com>>, RSP>,
    ST: {[_: $Keys<Com>]: any}
    >(
    mapStateToProps: MapStateToProps<S, SP, RSP>,
    mapDispatchToProps?: null
  ): (component: Com) => ComponentType<CP & SP> & $Shape<ST>;

Look at all those Objects and anys. 😢

Alternatively an ESLint-based fix would be great, if someone can find a rule that works for this.