Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessageList long loading logs #4180

Merged
merged 6 commits into from
Jul 6, 2020
Merged

MessageList long loading logs #4180

merged 6 commits into from
Jul 6, 2020

Commits on Jul 6, 2020

  1. msglist: Log to Sentry if the WebView setup is taking too long.

    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    5044a7b View commit details
    Browse the repository at this point in the history

  2. msglist types: Make details.error an Error in MessageListEventError. 

    `mixed` is too general and implies that it could be something that's
not JSONable. We could just use JSONable, but in the one place we
emit these events, it's an `Error`. [1]

[1]: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/.23M4156.20Message.20List.20placeholders/near/921072.
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    af6ddbb View commit details
    Browse the repository at this point in the history

  3. msglist: Use extras in logging.error for 'error' events from WebView.

    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    f29493d View commit details
    Browse the repository at this point in the history

  4. msglist: Add 'warn' message list event. 

    For sending warnings from within the WebView outwards.
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    2eb46d4 View commit details
    Browse the repository at this point in the history

  5. msglist types: Make WebViewUpdateEventMessagesRead exact, like the ot… 

    …hers.
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    77e66bd View commit details
    Browse the repository at this point in the history

  6. msglist: Hasty logging code, for long waits with placeholders. 

    In steady state, these changes should be reverted or structured a
bit better; it feels a bit haphazard.

If the placeholders are still visible after 10 seconds, send a log
to Sentry with all the events the WebView has received, with
timestamps of receipt. Redact any `auth` fields by replacing the
value with "redacted", and redact any `content` fields by extracting
just the opening tag for the "message-loading" div so we can see if
it has the "hidden" class.

But we want to debug zulip#4156 ASAP,

[1]: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/.23M4156.20Message.20List.20placeholders/near/921700
    @chrisbobbe @gnprice
    chrisbobbe authored and gnprice committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    523b307 View commit details
    Browse the repository at this point in the history