accountsReducer: Remove unhelpful test. #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
changed the title
chrisbobbe
force-pushed
the
pr-rm-confusing-test
branch
2 times, most recently
from
026717e
to
013eb9a
Compare
With Flow v0.113.0, which we'll get in the RN v0.61 -> v0.62 upgrade (zulip#3782), red flags are raised about this test. Strangely [1], the test was allowed to expect the `zulipVersion` on an Account to be undefined. In fact, the type for it is `ZulipVersion | null`. The test is based on the false premise that a REALM_INIT action might not have a `zulipVersion` property. `RealmInitAction` states that it will always be there, as a ZulipVersion instance. So, delete the test. If we ever find that there's a legitimate case where it is missing, we'll fix the RealmInitAction type accordingly, and a new test can proceed from there. [1] I think the culprit is very likely facebook/flow#6715, which Ray reported as being fixed in Flow v0.111.1, at zulip#4046 (comment)
gnprice
force-pushed
the
pr-rm-confusing-test
branch
from
013eb9a
to
4b5aaba
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Flow v0.113.0, which we'll get in the RN v0.61 -> v0.62 upgrade
(#3782), red flags are raised about this test. Strangely, the test
was allowed to expect the
zulipVersionon an Account to beundefined. In fact, the type for it is
ZulipVersion | null.The test is based on the false premise that a REALM_INIT action
might not have a
zulipVersionproperty.RealmInitActionstatesthat it will always be there, as a ZulipVersion instance. So, delete
the test. If we ever find that there's a legitimate case where it is
missing, we'll fix the RealmInitAction type accordingly, and a new
test can proceed from there.