model: Remove various fallbacks for ancient, sometimes prehistoric servers #5706
Conversation
There was a problem hiding this comment.
Thanks! LGTM. One nit:
dbfe7fc presence model tests: Remove one that expects fallback we don't need
7e4c131 fetchActions [nfc]: Remove already-done TODO about ancient servers 🎉
145aeea mute model: Remove ancient-server support from the reasons for a fallback
09dc8d3 model: Remove various fallbacks for ancient, sometimes prehistoric servers
I'd shorten two of those prefixes to "presence tests:" and "mute:" — I don't think the extra specificity of "model" helps there.
Yeah. I'll take a quick look at what it's like to rebase that. |
We removed the explicit fallback code this was testing in b945442. As it turns out, the way we use Immutable.Map (new in that commit's same PR) effectively handles the ancient-server behavior as well as the explicit fallback was, and so this test still passes. But that's incidental and not something we need to guarantee.
We took care of this in 3b811d6.
…rvers This completes all our `TODO(zulip#5102)`s.
|
Thanks for the review! Merging, with those commit-message edits. |
chrisbobbe
force-pushed
the
pr-remove-ancient-fallbacks
branch
from
09dc8d3
to
cbf8b3a
Compare
|
Rebased that and sent a draft PR, #5708. |
(We removed one such fallback in b945442 / #5697, but there were more; remove those.)
This completes all our
TODO(#5102)s in the code, referring to #5102.Greg, I think you have a draft for handling some other
TODO(server-x)s, possible with our currentkMinAllowedServerVersionof 2.0? Not urgent, but perhaps we'll want to take care of those sometime.