Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provision: Add provision support for Ubuntu 20.10(Groovy). #17170

Merged
merged 3 commits into from Feb 5, 2021

Conversation

ganpa3
Copy link
Collaborator

@ganpa3 ganpa3 commented Feb 1, 2021

PostgreSQL 13 is used when os_version is 20.10.

This will be useful for someone with Ubuntu 20.10 as the host or
wants to use the latest Ubuntu in vagrant setup.

Testing plan:

GIFs or screenshots:

@timabbott
Copy link
Sponsor Member

@ganpa3 just to confirm, were you able to successfully pass the backend tests after just these changes?

@ganpa3
Copy link
Collaborator Author

ganpa3 commented Feb 2, 2021

Oh! Forgot to add the postgresql.conf template.

@ganpa3
Copy link
Collaborator Author

ganpa3 commented Feb 2, 2021

@timabbott To confirm, I tested this PR on a new vagrant setup.
I ran ./tools/test-all on the master branch and all the tests passed successfully.

@ganpa3
Copy link
Collaborator Author

ganpa3 commented Feb 2, 2021

puppeteer tests have been failing non-deterministically for quite some time now.
Upstream issue puppeteer/puppeteer#3347

@andersk
Copy link
Member

andersk commented Feb 2, 2021

@ganpa3 That upstream issue is closed because its test case is incorrect. We need to file a new issue with a correct test case if we want anyone to pay attention.

This is a prep commit to add provision support for Ubuntu 20.10 Groovy.
PostgreSQL 13 is used when os_version is 20.10.
@timabbott timabbott merged commit 7eeca9d into zulip:master Feb 5, 2021
@timabbott
Copy link
Sponsor Member

Merged, thanks @ganpa3!

@ganpa3 ganpa3 deleted the support-for-ubuntu-groovy branch February 6, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants