ts: Convert emoji.js to TypeScript.

[Lalit3716]

Converted emoji.js to TypeScript by adding relevant type definitions, also modified target option in our tsconfig to 'ES2022' so that types for object methods like hasOwn which is being used in emoji.js are included.

Self-review checklist

• Self-reviewed the changes for clarity and maintainability
  (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

• Explains differences from previous plans (e.g., issue description).
• Highlights technical choices and bugs encountered.
• Calls out remaining decisions and concerns.
• Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

• Each commit is a coherent idea.
• Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

• Visual appearance of the changes.
• Responsiveness and internationalization.
• Strings and tooltips.
• End-to-end functionality of buttons, interactions and flows.
• Corner cases, error conditions, and easily imagined bugs.

[PIG208]

diff --git a/.eslintrc.json b/.eslintrc.json
index c3cabcdac5..b126a19af3 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -140,6 +140,8 @@
         {
             "files": ["web/src/**"],
             "globals": {
+                "Iterator": true,
+                "IterableIterator": true,
                 "StripeCheckout": false
             }
         },

Adding Iterator and IterableIterator to .eslintrc.json should fix the issue.

[Lalit3716]

Yep that fixed it thanks @PIG208 !

[andersk]

This seems to be

• fix: update getLib for new TypeScript targets ES2021, ES2022 typescript-eslint/typescript-eslint#6782

Ideally, we don’t want to have to manually list all the ES2022 globals we use. Until that fix is merged, try using target: "ESNext" instead.

[Lalit3716]

@andersk That worked too so changed "ES2022" -> "ESNext".

[Lalit3716]

Removed unnecessary map export const deactivated_emoji_name_to_code = new Map();, ready for another review now!

[timabbott]

Thanks for the work on this @Lalit3716! I posted a bunch of comments, mostly on naming -- I think my main advice is to spend more time thinking about what to call types, and if you're not sure, consider posting in #frontend to get feedback -- names are really important to the readability of code, and a big part of the benefit of moving to TypeScript is having named types for things, so it's definitely well worth our time to try to name things well. Usually there's pretty good hints in the names of the functions etc. that use a given type.

[Lalit3716]

Thanks for the review! Also I will make sure to take my time with naming things in my future work!, will update the PR soon 🙂.

[Lalit3716]

@timabbott This is ready to review.

I have addressed all the review comments and made a prep commit for the suggested refactoring.

[timabbott]

This is great, merged, thanks @Lalit3716!