-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recent-conversations: Not completely rerender for a single message #30066
base: main
Are you sure you want to change the base?
Conversation
…message Updates recent_view_ui.process_messages to have a check before rerendering, so rerendering one single message can be done with inplace_rerender instead of complete_rerender.
Hello @lumpleme, it seems like you have referenced #23638 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage. Please run An example of a correctly-formatted commit:
To learn how to write a great commit message, please refer to our guide. |
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: web/src/recent_view_ui.js
Did you find this useful? React with a 👍 or 👎 |
complete_rerender(); | ||
if (messages.length === 1) { | ||
// inplace_rerender for a single message | ||
const topic_key = recent_view_util.get_key_from_message(messages[0]); | ||
inplace_rerender(topic_key); | ||
} else { | ||
complete_rerender(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to modify inplce_rerender
fix the current position of the topic.
Heads up @lumpleme, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Updates recent_view_ui.process_messages to have a check before rerendering, so rerendering one single message can be done with inplace_rerender instead of complete_rerender.
Fixes: #23638