New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add new GDZW7-ECO - Ecolink 700 Series Garage Door Controller #6572
base: master
Are you sure you want to change the base?
Conversation
@AlCalzone What is the best way to test configs on the ui? I'm running zwave-js-ui on a docker container. Am I able to copy the configs into the container and re-integrate the device to test these changes? Do you know the location if that is the easiest way? Thanks. Edit: I put them into my volume mount: |
@AlCalzone ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay - I just got back from parental leave. I'd have fixed this myself, but the comments about the defaults left me confused...
What are the default values the device has when freshly reset and paired? The ones in the JSON file or the ones in the comments behind them?
Other than that I have a few minor remarks:
Co-authored-by: AlCalzone <d.griesel@gmx.net>
Co-authored-by: AlCalzone <d.griesel@gmx.net>
Co-authored-by: AlCalzone <d.griesel@gmx.net>
I have updated the default values to the one from the device firmware. The others were from the manual, which i have removed. @AlCalzone Ready for review |
Fixes #6570
Changes
GDZW7-ECO - Ecolink 700 Series Garage Door Controller
Testing artifacts