Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add new GDZW7-ECO - Ecolink 700 Series Garage Door Controller #6572

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

zackbcom
Copy link
Contributor

@zackbcom zackbcom commented Dec 27, 2023

Fixes #6570

Changes

Testing artifacts

  • I have tested this on the UI.
    • image
    • image

@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Dec 27, 2023
@zackbcom zackbcom changed the title feat(config): init for gdzw7-eco Draft: feat(config): init for gdzw7-eco Dec 27, 2023
@zackbcom zackbcom changed the title Draft: feat(config): init for gdzw7-eco feat(config): init for gdzw7-eco Dec 28, 2023
@zackbcom zackbcom changed the title feat(config): init for gdzw7-eco feat(config): add new GDZW7-ECO - Ecolink 700 Series Garage Door Controller Dec 29, 2023
@zackbcom zackbcom changed the title feat(config): add new GDZW7-ECO - Ecolink 700 Series Garage Door Controller Draftfeat(config): add new GDZW7-ECO - Ecolink 700 Series Garage Door Controller Dec 30, 2023
@zackbcom zackbcom changed the title Draftfeat(config): add new GDZW7-ECO - Ecolink 700 Series Garage Door Controller Draft: feat(config): add new GDZW7-ECO - Ecolink 700 Series Garage Door Controller Dec 30, 2023
@zackbcom
Copy link
Contributor Author

zackbcom commented Jan 1, 2024

@AlCalzone What is the best way to test configs on the ui?

I'm running zwave-js-ui on a docker container. Am I able to copy the configs into the container and re-integrate the device to test these changes? Do you know the location if that is the easiest way?

Thanks.

Edit: I put them into my volume mount: /store/.config-db/devices/... and got them to work.

@zackbcom zackbcom changed the title Draft: feat(config): add new GDZW7-ECO - Ecolink 700 Series Garage Door Controller feat(config): add new GDZW7-ECO - Ecolink 700 Series Garage Door Controller Feb 10, 2024
@zackbcom
Copy link
Contributor Author

@AlCalzone ready for review

Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay - I just got back from parental leave. I'd have fixed this myself, but the comments about the defaults left me confused...
What are the default values the device has when freshly reset and paired? The ones in the JSON file or the ones in the comments behind them?

Other than that I have a few minor remarks:

packages/config/config/devices/0x014a/gdzw7-eco.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x014a/gdzw7-eco.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x014a/gdzw7-eco.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x014a/gdzw7-eco.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x014a/gdzw7-eco.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x014a/gdzw7-eco.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x014a/gdzw7-eco.json Outdated Show resolved Hide resolved
@zackbcom
Copy link
Contributor Author

zackbcom commented Apr 11, 2024

Sorry for the delay - I just got back from parental leave. I'd have fixed this myself, but the comments about the defaults left me confused... What are the default values the device has when freshly reset and paired? The ones in the JSON file or the ones in the comments behind them?

Other than that I have a few minor remarks:

I have updated the default values to the one from the device firmware. The others were from the manual, which i have removed.

@AlCalzone Ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing device configuration: Ecolink 700 Series Garage Door Controller GCZW7-ECO
2 participants