Use sendCommand in NoOperationCC #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
force-pushed
the
refactor-noop-cc
branch
from
fe90f43
to
ed052cb
Compare
AlCalzone
force-pushed
the
refactor-noop-cc
branch
from
ed052cb
to
2a1cbbd
Compare
AlCalzone
force-pushed
the
refactor-noop-cc
branch
from
2a1cbbd
to
6fb6d52
Compare
|
This pull request introduces 349 alerts and fixes 5 when merging 6fb6d522f04f78f2fbfe8a892ffd536e4d21fad6 into df85c58 - view on LGTM.com new alerts:
fixed alerts:
|
AlCalzone
force-pushed
the
refactor-noop-cc
branch
from
6fb6d52
to
ce397f4
Compare
AlCalzone
force-pushed
the
refactor-noop-cc
branch
2 times, most recently
from
32fecf5
to
52a32f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without #602 we run into a circular reference, so this is blocked for now.
Edit: The removed import of
SendDataRequestis responsible for the test failure. 🤷♂️