Change the line parsing and storage approach to reduce the overall line processing time #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeKar
force-pushed
the
feature/perf-rune-lines
branch
from
8d1c0b1
to
9173d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention came up out of the discussion for #3127.
We realized that the line is processed multiple times as bytes to receive the resulting runes and their count.
This can be significantly reduced by storing already the decoded runes per line while parsing that line the first time. Afterwards this line doesn't need to be decoded again and the count can be accessed by a simple usage of
len().Since this is a huge rework and change of one of the basics it might brake one or more interfaces used by plugins.
The change is still ongoing and a lot of depending functionalities need to be changed. So please expect rebases from time to time.
I created the PR anyway since a lot of very important discussion was already ongoing within #3127 which shall be continued in here to keep the former one clean now.
In case someone else likes to support here then please provide patches and I can apply them. Otherwise please respect, that this can't be handled by me alone within a few days only, since I can't spend my whole free time for that. 馃槈
BTW:
make testruns successfully already.