Fix #1242 Dot Pathing in data file paths #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dots in the global datafile path leads to data beeing incorrectly nested. This commits changes the behavior so a datafile a.b.json will create an entry with data["a.b"] instead of data.a.b. The old behavior was a bug according to 11ty#1242. The implementation makes use of lodashs set and get functions which also take object paths in array form instead of string. That way we can implement this safely. Signed-off-by: Raphael Höser <raphael@hoeser.info>
This commit adds an additional testcase for 11ty#1242 to avoid future regressions. Signed-off-by: Raphael Höser <raphael@hoeser.info>
Snapstromegon
commented
Jul 29, 2021
|
I think this PR introduces a major version bump change, because it breaks compatibility to existing projects that might use the bug this fixes as a feature. Because of this I would recommend to either make the "bug" in #1242 an official feature, or to include this in 1.0. |
zachleat
added
the
breaking-change
|
It’s happening!! Thank you! 2.0.0-canary.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dots in the global datafile path leads to data beeing incorrectly nested.
This commits changes the behavior so a datafile a.b.json will create an entry with data["a.b"] instead of data.a.b.
The old behavior was a bug according to #1242.
The implementation makes use of lodashs set and get functions which also take object paths in array form instead of string. That way we can implement this safely.
fixes #1242