Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1242 Dot Pathing in data file paths #1912

Merged
merged 2 commits into from
May 10, 2022
Merged

Fix #1242 Dot Pathing in data file paths #1912

merged 2 commits into from
May 10, 2022

Commits on Jul 29, 2021

  1. Fix 11ty#1242 Dot-Pathing 

    Dots in the global datafile path leads to data beeing incorrectly nested.
This commits changes the behavior so a datafile a.b.json will create an entry with data["a.b"] instead of data.a.b.
The old behavior was a bug according to 11ty#1242.

The implementation makes use of lodashs set and get functions which also take object paths in array form instead of string. That way we can implement this safely.

Signed-off-by: Raphael Höser <raphael@hoeser.info>
    @Snapstromegon
    Snapstromegon committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    05468df View commit details
    Browse the repository at this point in the history

  2. Add test for 11ty#1242 

    This commit adds an additional testcase for 11ty#1242 to avoid future regressions.

Signed-off-by: Raphael Höser <raphael@hoeser.info>
    @Snapstromegon
    Snapstromegon committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    69c37b4 View commit details
    Browse the repository at this point in the history