Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing RebootRequired for SYSID_THISMAV #26569

Closed

Conversation

patrickelectric
Copy link
Member

The parameter only takes effect if the vehicle reboots

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@Williangalvani
Copy link
Contributor

Williangalvani commented Mar 20, 2024

it looks like tracker, plane, and rover update it in th 1hz loop. We should probably update sub instead to do this too.

@Williangalvani
Copy link
Contributor

maybe this? I haven't tested yet
#26570

@amilcarlucas
Copy link
Contributor

These parameters should probably be changed to the AP_Vehicle class

@rmackay9
Copy link
Contributor

I agree with @Williangalvani that we should add that update to the 1hz loop in Sub.

@patrickelectric
Copy link
Member Author

This should be replaced by: #26570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants