Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iris: Added iris model with 3d gimbal and yaw joint control #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snktshrma
Copy link

@snktshrma snktshrma commented Feb 29, 2024

Added gimbal_small_3d model to Iris and added yaw control channel as 6 to AP plugin. Used the same world as gimbal.sdf world.
I'll make changes to the world or existing models as the maintainers say.

@srmainwaring
Copy link
Collaborator

Hi @snktshrma, thanks for the PR. Rather than add a new model and world we could do the following with the Iris:

  1. Change the 2D gimbal in the iris_with_gimbal model for the 3D version with the zoom, and add the extra joint controller and control block.
  2. Use the iris_with_gimbal in the iris_runway.sdf and iris_warehouse.sdf worlds.

This keeps the number of models and worlds to maintain in this repo down, and makes the camera equipped model the default. The default params (gazebo-iris) in the ardupilot repo would not be configured to control the camera, but we could provide an additional set, and in the meanwhile the camera and gimbal could still be controlled using the gz topics.

Thoughts?

@srmainwaring srmainwaring self-assigned this Mar 4, 2024
@srmainwaring srmainwaring added the enhancement New feature or request label Mar 4, 2024
@srmainwaring srmainwaring self-requested a review March 4, 2024 21:14
@snktshrma
Copy link
Author

Hey @srmainwaring ! That seems fine! I have made the required changes and will push them asap!

@snktshrma
Copy link
Author

snktshrma commented Mar 9, 2024

@srmainwaring I have made the changes you mentioned. Regarding gimbal control though gz topic, that seems feasible for the time being I'd say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants