infra: migrate to ts project references #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
AviVahl
commented
Jun 12, 2020
AviVahl
commented
- must first build, then test/lint, but everything is faster.
- tests are now running from ./dist. native source maps enabled (and work on node 12+).
- moved ts-build bin entry to ./bin.
- simplified all "scripts" in repo. less dependency on lerna.
|
Might be blocked by typescript-eslint/typescript-eslint#2094 The current linting experience with project references leaves much to be desired. While building helps the eslint cli to pass, vscode-eslint has a stale state showing no-longer-true lint errors (which are gone once vscode restarted). Also, the fact that you have to build in order to run lint is also very annoying. Type checking and completions work out of the box without building, so this is obviously possible. |
AviVahl
force-pushed
the
ts-project-references
branch
from
5a5220b
to
abafb68
Compare
fabz99-star
approved these changes
Jun 21, 2020
- must first build, then test/lint, but everything is faster. - tests are now running from ./dist. native source maps enabled (and work on node 12+). - moved ts-build bin entry to ./bin. - simplified all "scripts" in repo. less dependency on lerna.
still doesn't auto-detect github actions ootb...
AviVahl
force-pushed
the
ts-project-references
branch
from
abafb68
to
3cf33a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.