Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(Data Mapper): Refactoring deserialization for v2 #4800

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Feat(Data Mapper): Refactoring deserialization for v2 #4800

wants to merge 30 commits into from

Conversation

DanielleCogs
Copy link
Contributor

@DanielleCogs DanielleCogs commented May 7, 2024 •
edited

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    refactor

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    deserialization is easier to understand, and should have less bugs!
    Not completely done yet, so tests that are not passing are disabled

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Please Include Screenshots or Videos of the intended change:

image

image

Danielle Cogburn and others added 29 commits January 3, 2024 20:26
made progress on refactor
cf4b2ba
added new file and first few tests pass
60009d6
simple function works
eea9593
index loops work
f947582
more tests pass
8b4f7b1
get source node for loops
c4a500b
nested functions pass test
ac998fa
some conditionals pass
3b13024
starting on direct access
0223fd2
loop improvements
07afbdf
@DanielleCogs
Merge branch 'main' of https://github.com/Azure/logic_apps_designer i…
d74c5d7 
…nto deserialization-refactor
@DanielleCogs
working on conditionals and custom values
e574e42
@DanielleCogs
working on conditionals and custom values
dec6562
@DanielleCogs
Merge branch 'main' of https://github.com/Azure/logic_apps_designer i…
de85b8c 
…nto deserialization-refactor
@DanielleCogs
conditional property connection works
18775ac
@DanielleCogs
direct access works
40f407c
@DanielleCogs
conditionals and refactor
1d63fae
@DanielleCogs
conditionals and refactor
4e4b03d
@DanielleCogs
Merge branch 'main' of https://github.com/Azure/logic_apps_designer i…
5fa613b 
…nto deserialization-refactor
@DanielleCogs
sequences tests pass
8889e7f
@DanielleCogs
value works
fa8155b
@DanielleCogs
refactor
f04f5a8
@DanielleCogs
improving looping
9bc4e37
@DanielleCogs
starting to add new type for single values
4da2dad
@DanielleCogs
started moving into v2
2ea99c3
@DanielleCogs
moved to v2
98da0d4
@DanielleCogs
Merge branch 'main' of https://github.com/Azure/logic_apps_designer i…
e68fffe 
…nto deserialization-refactor
@DanielleCogs
skip failing test
a6d5793
@DanielleCogs
resetting deserialization
15db29f
@DanielleCogs DanielleCogs changed the title DRAFT: Deserialization refactor Feat(Data Mapper): Refactoring deserialization for v2 May 18, 2024
@DanielleCogs DanielleCogs marked this pull request as ready for review May 18, 2024 23:14
@github-actions GitHub Actions
Copy link

Code Coverage Report

Code Coverage

Package Base Coverage New Coverage Difference
mapHandling 🔴 9.09% 🟢 83.54% 🟢 74.45%
utils 🔴 45.86% 🟠 51.37% 🟢 5.51%
Overall Coverage 🟢 21.06% 🟢 26.18% 🟢 5.12%

Minimum allowed coverage is 0%, this run produced 26.18%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takyyon takyyon takyyon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanielleCogs @takyyon