Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Data Mapper): Refactoring deserialization for v2 #4800

Merged
merged 32 commits into from
May 22, 2024
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
cf4b2ba
made progress on refactor
Jan 4, 2024
60009d6
added new file and first few tests pass
Jan 9, 2024
eea9593
simple function works
Jan 9, 2024
f947582
index loops work
Jan 9, 2024
8b4f7b1
more tests pass
Jan 11, 2024
c4a500b
get source node for loops
Jan 11, 2024
ac998fa
nested functions pass test
Jan 18, 2024
3b13024
some conditionals pass
Jan 18, 2024
0223fd2
starting on direct access
Jan 23, 2024
07afbdf
loop improvements
Jan 25, 2024
d74c5d7
Merge branch 'main' of https://github.com/Azure/logic_apps_designer i…
DanielleCogs Apr 16, 2024
e574e42
working on conditionals and custom values
DanielleCogs Apr 17, 2024
dec6562
working on conditionals and custom values
DanielleCogs Apr 17, 2024
de85b8c
Merge branch 'main' of https://github.com/Azure/logic_apps_designer i…
DanielleCogs Apr 18, 2024
18775ac
conditional property connection works
DanielleCogs Apr 19, 2024
40f407c
direct access works
DanielleCogs Apr 22, 2024
1d63fae
conditionals and refactor
DanielleCogs Apr 23, 2024
4e4b03d
conditionals and refactor
DanielleCogs Apr 23, 2024
5fa613b
Merge branch 'main' of https://github.com/Azure/logic_apps_designer i…
DanielleCogs Apr 23, 2024
8889e7f
sequences tests pass
DanielleCogs Apr 24, 2024
fa8155b
value works
DanielleCogs Apr 26, 2024
f04f5a8
refactor
DanielleCogs May 3, 2024
9bc4e37
improving looping
DanielleCogs May 6, 2024
4da2dad
starting to add new type for single values
DanielleCogs May 8, 2024
2ea99c3
started moving into v2
DanielleCogs May 8, 2024
98da0d4
moved to v2
DanielleCogs May 9, 2024
e68fffe
Merge branch 'main' of https://github.com/Azure/logic_apps_designer i…
DanielleCogs May 14, 2024
a6d5793
skip failing test
DanielleCogs May 14, 2024
15db29f
resetting deserialization
DanielleCogs May 16, 2024
3264556
removed unused code
DanielleCogs May 19, 2024
1c0a494
added docs
DanielleCogs May 21, 2024
e7097be
fixed doc
DanielleCogs May 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions Localize/lang/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,6 @@
"7ZR1xr": "Add an action",
"7aJqIH": "Optional. The locale to be used when formatting (defaults to 'en-us').",
"7gUE8h": "This will revert your workflow to the state it was in before Copilot's edit. If you made additional edits to the workflow after Copilot's, you will lose them. This action cannot be undone. Do you want to continue?",
"7jAQar": "Enter value for parameter.",
"7jcTNd": "Enter a valid email.",
"7k9jXx": "Status code",
"7lnElz": "Returns the number of ticks (100 nanoseconds interval) since 1 January 0001 00:00:00 UT of a string timestamp",
Expand Down Expand Up @@ -1156,7 +1155,6 @@
"_7ZR1xr.comment": "Text on example action node",
"_7aJqIH.comment": "Optional locale parameter to apply formatNumber function with",
"_7gUE8h.comment": "Warning description of what undoing operation will do to the workflow",
"_7jAQar.comment": "Parameter Field Default Value Placeholder Text",
"_7jcTNd.comment": "Error validation message for emails",
"_7k9jXx.comment": "Label text for response status code",
"_7lnElz.comment": "Label for description of custom ticks Function",
Expand Down Expand Up @@ -2133,7 +2131,6 @@
"_mGUdCO.comment": "Label for description of custom getPastTime Function",
"_mGpKsl.comment": "Label for description of custom dataUriToString Function",
"_mNaBPE.comment": "Error message for invalid JSON in authentication editor",
"_mOxbN1.comment": "Parameter Field Default Value Title",
"_mPakaD.comment": "Label for description of custom encodeUriComponent Function",
"_mPuXlv.comment": "Error message for when split on array is invalid. Do not remove the double single quotes around the placeholder text, as it is needed to wrap the placeholder text in single quotes.",
"_mUURJW.comment": "Tooltip for the button to reassign actions",
Expand Down Expand Up @@ -2216,7 +2213,6 @@
"_pMms92.comment": "Label for button to open dynamic content picker",
"_pOTcUO.comment": "Required object parameter to be converted to array using createArray function",
"_pOVDll.comment": "Error validation message for Integers",
"_pRUJff.comment": "Create Title",
"_pXmFGf.comment": "Label for description of custom xml Function",
"_pYNzbj.comment": "The title of the path field in the static result parseJson action",
"_pYtSyE.comment": "Required number parameter to divide the dividend by in mod function",
Expand Down Expand Up @@ -2779,7 +2775,6 @@
"mGUdCO": "Returns a timestamp that is the current time minus the specified time interval.",
"mGpKsl": "Returns a string representation of a data URI",
"mNaBPE": "Enter a valid JSON.",
"mOxbN1": "Value",
"mPakaD": "Url encodes the input string",
"mPuXlv": "Invalid type on split on value ''{splitOn}'', split on not in array.",
"mUURJW": "Connection is invalid",
Expand Down Expand Up @@ -2862,7 +2857,6 @@
"pMms92": "Insert Dynamic Content",
"pOTcUO": "Required. The values to combine into an array.",
"pOVDll": "Enter a valid integer.",
"pRUJff": "Parameters",
"pXmFGf": "Covert the input to an Xml type value",
"pYNzbj": "Path",
"pYtSyE": "Required. The number to divide the Dividend by. After the division, the remainder is taken.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const DataMapperStandaloneDesignerV1 = () => {
const isLightMode = theme === ThemeType.Light;

return (
<div style={{ flex: '1 1 1px', display: 'flex', flexDirection: 'column' }}>
<div style={{ flex: '1 1 1px', display: 'flex', flexDirection: 'column', height: '100vh' }}>
<div style={{ flex: '0 1 1px' }}>
<ThemeProvider theme={isLightMode ? AzureThemeLight : AzureThemeDark}>
<FluentProvider theme={isLightMode ? webLightTheme : webDarkTheme}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export const DataMapperStandaloneDesignerV2 = () => {
const isLightMode = theme === ThemeType.Light;

return (
<div style={{ flex: '1 1 1px', display: 'flex', flexDirection: 'column' }}>
<div style={{ flex: '1 1 1px', display: 'flex', flexDirection: 'column', height: '100%' }}>
<div style={{ flex: '0 1 1px' }}>
<ThemeProvider theme={isLightMode ? AzureThemeLight : AzureThemeDark}>
<FluentProvider theme={isLightMode ? webLightTheme : webDarkTheme}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,17 @@
"children": []
}
]
},
{
"key": "/ns0:SourceSchemaRoot/Conditionals/SourceProperty2",
"name": "SourceProperty2",
"qName": "SourceProperty2",
"parentKey": "/ns0:SourceSchemaRoot/Conditionals",
"type": "String",
"properties": "None",
"children": []
}

]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export const mapNodeParams = {
for: '$for',
if: '$if',
value: '$value',
backout: '../'
};

export const reservedMapNodeParamsArray: string[] = [mapNodeParams.for, mapNodeParams.if, mapNodeParams.value];
Expand Down