autorest/adal: update modules, and switch to github.com/golang-jwt/jwt v4.0.0 #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@brackendawson @jhendrixMSFT PTAL (hope I did the |
|
oh! this probably requires Go to be updated; see distribution/distribution#3472 go-autorest/azure-pipelines.yml Lines 10 to 16 in 778ae56 |
2 tasks
thaJeztah
changed the title
thaJeztah
force-pushed
the
update_jwt
branch
2 times, most recently
from
1b26c25
to
b44fbae
Compare
thaJeztah
commented
Aug 23, 2021
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The github.com/form3tech-oss/jwt-go fork has been archived, and all development is moved to the github.com/golang-jwt/jwt project, which is now the canonical/official fork of github.com/dgrijalva/jwt-go. The latest version of github.com/golang-jwt/jwt (v4.0.0) also adds go module support, but the main github.com/Azure/go-autorest package currently uses "go dep", which is not compatible with go modules that use versioned import paths (github.com/golang-jwt/jwt/v4) for modules that do not use a `v<version>` directory. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Go Dep does not support versioned module paths, so we may as well remove it. Note that I did not add a `go.mod` at the root of the repository. The roof ot this repository is an empty module, and adding a go.mod will require a major version update, to adjust the name to match the current release (v14). Given that (from the README), the "main" tags were intended for projects that have not yet migrated to modules, adding a go.mod will not benefit those consumers. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Now that the GoDep file is removed from the root, we can move this module to use v4. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
merge code coverage files then report
thaJeztah
force-pushed
the
update_jwt
branch
2 times, most recently
from
4895140
to
4cb2949
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
jhendrixMSFT
approved these changes
Aug 24, 2021
|
Thanks for your help on this. |
|
You're welcome! Thanks for review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #642
fixes #648
The github.com/form3tech-oss/jwt-go fork has been archived, and all
development is moved to the github.com/golang-jwt/jwt project, which
is now the canonical/official fork of github.com/dgrijalva/jwt-go.
The latest version of github.com/golang-jwt/jwt (v4.0.0) also adds
go module support, but the main github.com/Azure/go-autorest package
currently uses "go dep", which is not compatible with go modules that
use versioned import paths (github.com/golang-jwt/jwt/v4) for modules
that do not use a
v<version>directory.As part of submitting, please make sure you can make the following assertions: